GSoC 2023: Improve Waveform drawing speed

Contributing to Blender Summer of Code
5

Week 4 Report: June 19th to June 25th

  • Got @iss’s help with the PR review and got some pointers on how to use WM_event_add_notifier

  • Stumbled on an issue trying to use WM_event_add_notifier and spent some time investigating the issue:

    • Just before an audio object is submitted to the PreviewJob, it’s tags field is has the bit SOUND_FLAGS_WAVEFORM_LOADING. If we just exit call WM_event_add_notifier in the sequencer_preview_add_sound function, there will never be another attempt to enqueue the sound: The flag is never cleared.
    • I changed the code to clear the flag just before returning to get things working.

  • Not much progress due to another oncall week at work, but it’s finally done. Will have more time to move the project this week.

Next steps

  • Get the PR merged
  • Start looking into how we can compute waveforms only for visible strips
5 Likes