@leesonw Will, do.
On another note, I’m currently testing merging the rendered results of two sample ranges. I basically used the offset setting to render a contiguous sample sequence in two different renders by using the new offset setting. This produces the render results as open exr files as I had configured Blender to do that via the render properties panel in Blender’s UI as would any user do.
However, the operator bpy.ops.cycles.merge_images no longer seems to work.
I got this error
>>> bpy.ops.cycles.merge_images(input_filepath1=fp1, input_filepath2=fp2, output_filepath=fpo)
Error: No sample number specified in the file for layer Composite or on the command line
Traceback (most recent call last):
File "<blender_console>", line 1, in <module>
File "C:\Users\CrowdRender\git\build_windows_x64_vc16_Release\bin\Release\3.0\scripts\modules\bpy\ops.py", line 132, in __call__
ret = _op_call(self.idname_py(), None, kw)
RuntimeError: Error: No sample number specified in the file for layer Composite or on the command line
I traced the error back to here in then branch we’re working on (props to Pembem22 by the way who is immensely helpful and has been doing the programming for the patch). From inspecting this line of code, I think that there is an OCIO attribute not being set.
The attribute in question is queried in the above code like this;
in_spec.get_string_attribute("cycles." + name + ".samples", "");
So far, I’ve not been able to find a call to the OCIO’s attribute method to set this anywhere.
Might this have been removed? If so, we’ll put it back