Decoupling x-ray and limit selection to visible

Archive User Feedback
181

Nah it’s just a matter of looking through this bs moonlanguage to find what is different from before. Help me look through it if you can I will do some more tomorrow.

Found a much easier way to see what’s different than just skimming through it manually.

  1. Saved a copy of all the scripts from 2.83.5 (untouched, not with the select through patch) in another directory

  2. Right click script from 2.83->Tortoise SVN->Diff later

  3. Right click same script from 2.9->Tortoise SVN->Diff with “nameOfScript”

  4. Click next/previous difference, or go to the relevant line(s)

From what I can tell, there’s nothing going on in view3d_select or view3d_iterators.

It’s probably something that happens in what kio put inside of view3d_iterators under

void mesh_foreachScreenFaceVerts

So far I’ve checked

editbmesh_get_eval_cage_from_orig

which is in DerivedMesh.c and BKE_DerivedMesh.h - both of which seem fine.

Going to check the rest tomorrow, but like I said, if anybody out there has the time help me check it out and let us all know what you find, thanks

Quick update:

went through a few more scripts and wasn’t seeing anything, so I did a debug build for 2.90 with select through. It’s saying there’s something wrong with ‘mvert’ in the place I figured (void mesh_foreachScreenFaceVerts)

if (mvert->flag & ME_HIDE) {

Exception thrown: read access violation.
**mvert** was nullptr.

My guess is it might be named something else now, or something different is being done to it somewhere along the way. Either way it’s late, and it should be pretty easy to figure out now, definitely not jinxing myself by saying that.

Any help with this part?
In the select through patch, view3d_iterators.c, under ‘void mesh_foreachScreenFaceVerts’, around line 414 kio tells it to get the mesh:

  Mesh *mesh = editbmesh_get_eval_cage_from_orig(
      vc->depsgraph, vc->scene, vc->obedit, &CD_MASK_BAREMESH);

Then line 420 he gets the mverts of the mesh:

  const MVert *mvert = mesh->mvert;

In 2.9 this doesn’t work, it acts as if there aren’t any and keeps it NULL. This results in the read access violation I posted earlier, and nothing gets selected.

I tested this by adding some prints:

const MVert *mvert = mesh->mvert;
  if (mvert !=NULL) {
    printf("something in there \n");
  }
  else {
    printf("NULL \n");
  }

Now, in 2.83 it will always see something in there, even if you don’t select anything. It’s just checking if the mesh has stuff to select. If you delete all of the components of the mesh, then try selecting something, it will print ‘NULL’

In 2.9, always NULL.

Comparing ‘dna_meshdata_types.h’ between 2.83 and 2.9 reveals nothing. Almost no changes and nothing that seems relevant. Bit of a head scratcher :thinking:

Also, it sees a mesh in 2.9, just checked it. So the issue is somewhere in the check for mvert.

Alright so big thanks to @ideasman42 for helping me

At the very least there’s a quick workaround, but like he says, it aint pretty. To avoid all of that and the performance issues that will come with it, I got what I think should work.

Just send the Mesh from ‘view3d_select’ to ‘view3d_iterators’ instead of getting it in there and having some things get lost in translation. In short there’s some useful things coming that are being implemented for 2.90, but in some contexts there’s issues passing mesh data around.

Checked everything and it’s fully functional. I’ll do some performance tests like I did a while back to see what the gains are, because why not.

1 Like