The meeting will be on 2023-08-31T16:00:00Z. It is open for everybody interested to join on Google Meet (link below).
Present:
Alexander Gavrilov, Christoph Lendenfeld, Daniel Salazar, Eduardo Rubio, Harley Acheson, Ivan Cappiello, Jason Schleifer, Jeremy Bot, Nate Rupsis, Nathan Vegdahl
People present are referred to by first name for brevity. Others are referred to by full name.
Links
- Google Meet. Note that there are no recordings of the meeting. This way everybody is free to say or show anything.
- A&R Module Meetings agenda for inclusion in your own calendar
- Previous and next meeting notes
- Issues & Pull Requests
- #animation-module chat channel
Since the Last Meeting / Announcements
- Bone collections are in! Big thanks to both Christoph and Alexander for their help getting this landed!
Landed
- Bone collections:
- 042c5347f4b: Anim: move bone colors from bone groups to individual bones (Sybren A. StĂĽvel) (2023-08-22)
- 998136f7a7b: Anim: replace Bone Groups & Armature Layers with Bone Collections (Sybren A. StĂĽvel) (2023-08-22)
- 9eee076a299: Anim: add custom property support for Bone Collections (Nathan Vegdahl) (2023-08-25)
- f1111808b84: Fix: rename animation curves associated with bone collection properties (Alexander Gavrilov) (2023-08-26)
- 172a6d65a60: Fix: update BKE bone layer visibility checks to use bone collections (Nathan Vegdahl) (2023-08-29)
- a1f081c212a: Fix: uninitialized memory in bone collection unit tests (Nathan Vegdahl) (2023-08-29)
- 830572a1bbd: Anim: add python API for reordering bone collections (Alexander Gavrilov) (2023-08-26)
- ab67d410a90: Fix: set bone collection membership properly for new bones (Nathan Vegdahl) (2023-08-29)
- 6d2c7c509cc: Fix: failing keymap test for ARMATURE_OT_assign_to_collection (Nathan Vegdahl) (2023-08-29)
- 726ef2c8732: Fix: remove UI code relating to bone layers (Philipp Oeser) (2023-08-31)
- c75d6ae0ed5: Fix: Bone collection renaming when empty string (Pratik Borhade) (2023-08-31)
- daa4c0f91e: Fix: set default bone collection active (Pratik Borhade) (2023-08-31)
- 3f7eceea93f: Fix: Memory leak in Graph editor keyframe jump (Christoph Lendenfeld) (2023-08-24)
- 2cb5f83940a: Fix #97049: Auto-keyframe Status Message Overlaps Navigation Gizmo (Nate Rupsis) (2023-08-24)
- 05f8d61ec68: Fix: Blend to Ease keyframes property name (Christoph Lendenfeld) (2023-08-31)
- 9d0aed6589a: Animation: Shear operator for Graph Editor (Christoph Lendenfeld) (2023-08-31)
Short-term goals / Ongoing Work
- Stabilizing bone collections / colors:
- Bone collections and bone collection membership are not handled properly when undoing in armature edit mode #111780
- Unable to show/hide bone collection on library override armature #111711
- Feedback from Hjalti Hjálmarsson: missing use case from bone groups: seeing at-a-glance what bone colors are used in an armature, and for which sets of bones.
- Almost certainly more issues…
- Nathan still needs to write up the Animation Data Model MVP stuff.
- Christoph is continuing to work on graph editor improvements.
- Nate is working on #76549 - NLA Strip influence slider doesn't respond to autokey correctly. - blender - Blender Projects
Patch Review & Decision Time
- Harley: be aware, we’re making menu item order consistent: #109798 - UI: Consistent Menu/Block/Popup Content Ordering - blender - Blender Projects
- Harley: menus that are assumed to always be popping from the bottom, are now always reversed. So this will impact the order of animation editor menus.
- Nathan: seems fine. We’ll deal with reordering things if needed.
- Jason: us animators do normally put our editors at the bottom anyway.
- Daniel: does this affect Blender’s cool feature of always placing the last selected menu item under the cursor?
- Harley: that shouldn’t be affected.
- Ivan suggests having the selected and active bone colors always the same for all bones by default, only customizing the unselected color. Reason: the various selection colors are visually confusing. To the module: should we do this?
- Ivan: when animators try to customize the colors, they generally choose from the theme colors. Issue is that the predefined themes set the colors for all three states. And those colors aren’t very distinct between selection states.
- Ivan: users should still have the choice to modify the selected and active colors. It just shouldn’t be the default, and you should have to opt-in.
- Module is in favor of only customizing unselected color by default.
- Alexander & Christoph: should this be a user preference, or per rig, or per bone…?
- Ivan will put together a proposal / mock up, and more discussion about the specifics can happen based on that.
- Eduardo: related: bone colors are confusing when bones are solid shaded. For example, they can be outlined even when unselected, which can look selected.
- Module agrees we should also look into improving that.
Help Needed
- Testing of Bone Collection & Colors! Please file issues for any bugs/weirdness.
- 111 unclassified reports
- Quite a few merged PRs that need documentation. See the Animation & Rigging workboard for the list.
Next Meeting
The next meeting will be on Thursday 2023-09-07T16:00:00Z. Again it will be open for everybody who’s interested. The provisionary meeting agenda will be linked in the #animation-module channel before the meeting.