Error C2065: 'M_PI' and 'M_PI_2' Undeclared identifier in openvdb\math\Mat.h when building on Win 10 with MSVC 2019

Building Blender
1

Building Blender with make update followed by make on Win 10 with MSVC 2019.

Getting errors with OpenVDB:

C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(355,32): error C2065: 'M_PI_2': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(368,31): error C2065: 'M_PI_2': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(372,32): error C2065: 'M_PI': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(386,31): error C2065: 'M_PI_2': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(390,32): error C2065: 'M_PI': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(409,31): error C2065: 'M_PI': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(428,31): error C2065: 'M_PI': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(443,32): error C2065: 'M_PI_2': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(447,31): error C2065: 'M_PI_2': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(462,32): error C2065: 'M_PI_2': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(466,31): error C2065: 'M_PI_2': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(481,31): error C2065: 'M_PI_2': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
C:\blender-git\lib\win64_vc15\openvdb\include\openvdb\math\Mat.h(485,32): error C2065: 'M_PI_2': undeclared identifier [C:\blender-git\build_windows_x64_vc16_Release\intern\openvdb\bf_intern_openvdb.vcxproj]
    5 Warning(s)
    14 Error(s)```

At revision 62391
2

I can’t repro this on latest master, is this still an issue?

3

Thank you for taking the time to look into this.

I was bisecting an issue, and got a nonsensical result. I saw that I had mistakenly entered in the wrong git bisect good in the beginning, so I checked out a specific commit. I didn’t realize I was still on it instead of master when trying to build, apologies. So no this isn’t an issue any longer.