Attendees:
- Dalai Felinto
- Sergey Sharybin
Sergey and I got together to see the state of the Grease Pencil XR existing code and discuss next steps to propose the team.
For the records, this is based on the meeting we had in April together with the Grease Pencil XR developers (Lazaro Palafox and Samuel Palafox).
-
Let’s focus on the architecture design review before getting into deep code review.
-
The amount of changes [2] is not bad. This could be sent as a PR with a description of its architecture design for more review.
-
The original idea [1] of having a PR for one operator/brush is still a good idea.
-
The InputSample was expanded as discussed [1], so it can be re-used. However the sculpt_paint code is adding more permutation (i.e., a massive copy/paste in a new file), instead of re-using the newly introduced parameters in the existing functions/code. Making it hard to evaluate if this design is sound and adds low burden to existing code.
-
Grease Pencil outline modifier makes modifier dependent on the draw context / interface (depends on pixel size which is owned by the draw context - leading to the depedency on evil_C). In other places (e.g., on draw code), that dependency is probably less problematic.
The sugestion is for the team to create a PR with a description containing their current architecture design (and the basic code).
[1] - 2025-04-09 Grease Pencil VR.
[2] - on the branch gpencil3-xr-minimal-example.