2025-04-08 Blender Admins Meeting

Meetings
1

Attendees:

  • Campbell Barton
  • Jacques Lucke

Topics

  • Devtalk threads for the namespace guidelines have not been created yet.
    • It’s been tricky to write down the right arguments. That part was easier to when presenting live.
    • Jacques will work on it again.
  • Brief discussion about CC-ing developers in PRs to make them aware of a patch without adding all of them as reviewers.
    • That seems like the best approach for now. An alternative could be to add PRs to a module, but that does not seem to create a notify the module owner.
5 Likes
2

Hi, I don’t know the background behind this topic but CC-ing don’t actually subscribe them to PR. Either way, notified person just receives single email.

1 Like
3

I would indeed rather get too many review assignments than not (or mere CC’s).

Refusing to review something if you don’t have time or are not really involved in the area is trivial.

Finding out about things you should have checked, but were not formally asked to review, is usually painful and way more time consuming in the end.

1 Like
4

Being added as a reviewer doesn’t subscribe you either, surprisingly. So I always click the Subscribe button if it’s something I need to track.

5

Personally I’m ok with getting a CC, and then adding myself as a reviewer when needed.

It seems slightly simpler than the author having to communicate who they expect to review, though it’s not a big deal either way.

6

I also subscribe to the patches once I get a CC, I think this is ok.

I don’t think we gain much by abusing the amount of reviewers. It will lead to unclarity of whether the patch is waiting for someone. We already suffer a bit from this because there is no concept of “blocking” reviewers. This would just make the situation a bit worse.

2 Likes
7

(but yes if you are added as a reviewer I would expect to be automatically subscribed, maybe a gitea setup? or a PR on the making?)