Posting here my suggestions for changes in the dark color theme to make diffs more readable by toning down some backgrounds to be less distracting:
:root {
--color-box-body-highlight: hsla(204deg, 60%, 15%, .15);
--color-diff-inactive: hsl(229.4, 13.8%, 13%);
--color-diff-added-row-linesnum-bg: hsla(123, 36%, 40%, 0.2);
--color-diff-removed-row-linesnum-bg: hsl(0, 25%, 23%);
}
The idea is:
- The blue lines separating patch hunks should be way less prominent than file headers: visual priority should be red/green changes → file headers → everything else. In default phab color scheme they are very subtle, and I matched that.
- I think it is strange that in side by side view (e.g. this commit at random) ‘holes’ on the other side of additions/removals are brightly colored - I made them slightly darker than default background instead.
- Finally, in the same vein as the other changes, I made the color of the number column of red/green changes slightly closer to the non-number column.
Edit: it’s quite likely an actual designer could tune the colors even better - this is just a suggestion of the direction of change.
